Skip to content

Replace bash-style DR scripts with openshift-tests run-dr #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 1 commit into from
Closed

Replace bash-style DR scripts with openshift-tests run-dr #4355

vrutkovs wants to merge 1 commit into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jul 12, 2019

Requires openshift/origin#23208

This commit would replace bash-style DR CI scenarios with a proper e2e test. Several helper scripts for bastion_ssh were retained for e2e tests which use ssh bastion (see #4161)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jul 12, 2019

/cc @deads2k @runcom @abhinavdahiya

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jul 15, 2019

/hold

until Origin PR merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch 2 times, most recently from e7fdca0 to f83dbcd Compare July 16, 2019 10:43
@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch 5 times, most recently from 8dee68a to fcc2232 Compare July 31, 2019 12:10
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jul 31, 2019

These tests were added in openshift/origin#23208, but they are not listed in openshift-tests run openshift/disruptive --dry-run.

This is fixed in openshift/origin#23520

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 5, 2019

/retest

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 5, 2019

/test pj-rehearse

1 similar comment
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 6, 2019

/test pj-rehearse

@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch 3 times, most recently from d78fcbc to 038ed49 Compare August 8, 2019 11:20
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 8, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2019
hexfusion
hexfusion approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2019
@vrutkovs vrutkovs mentioned this pull request Aug 12, 2019
Merged
deads2k
deads2k reviewed Aug 12, 2019
View reviewed changes
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml Outdated
Copy link
Contributor

@deads2k deads2k Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not beautiful. but we could do worse.

@deads2k
Copy link
Contributor

deads2k commented Aug 12, 2019

looks like an improvement with less bash. That grep one liner rubs me the wrong way though.

/approve

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2019

New changes are detected. LGTM label has been removed.

@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch from 3f56603 to 038ed49 Compare August 12, 2019 14:43
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2019
@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch from 038ed49 to 57f42d9 Compare August 28, 2019 09:10
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, hexfusion, vrutkovs
To complete the pull request process, please assign ashcrow, wking
You can assign the PR to them by writing /assign @ashcrow @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Aug 30, 2019

/test pj-rehearse

@vrutkovs vrutkovs force-pushed the dr-replace-bash-tests branch from 57f42d9 to 1ffd7f1 Compare August 30, 2019 10:29
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2019

@vrutkovs: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2019

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-gcp d78fcbc9ea351f86166510d1e6b24fd6084b3570 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.3/e2e-aws-upgrade 57f42d9393b5ec0163739511d9901d3d60b0c2fd link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.1/e2e-aws-upgrade 57f42d9393b5ec0163739511d9901d3d60b0c2fd link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.2/e2e-aws-upgrade 57f42d9393b5ec0163739511d9901d3d60b0c2fd link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.3/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.2/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.2/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.3/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.3/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.3/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.1/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.1/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.2/e2e-etcd-quorum-loss 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.2/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-restore-cluster-state 1ffd7f1 link /test pj-rehearse
ci/prow/pj-rehearse 1ffd7f1 link /test pj-rehearse
ci/build-farm/build01-dry 1ffd7f1 link /test build01-dry
ci/prow/prow-config 1ffd7f1 link /test prow-config
ci/prow/step-registry-shellcheck 1ffd7f1 link /test step-registry-shellcheck
ci/prow/build-farm-consistency 1ffd7f1 link /test build-farm-consistency

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

petr-muller commented Dec 13, 2019

Stale PR, please adapt and reopen if still needed.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 13, 2019

@petr-muller: Closed this PR.

Details

In response to this:

Stale PR, please adapt and reopen if still needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@ashcrow ashcrow Awaiting requested review from ashcrow

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@runcom runcom Awaiting requested review from runcom

+1 more reviewer

@hexfusion hexfusion hexfusion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hexfusion hexfusion

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @deads2k @openshift-ci-robot @petr-muller @hexfusion